Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Actpool improve #3394

Closed
wants to merge 6 commits into from
Closed

Conversation

Liuhaai
Copy link
Member

@Liuhaai Liuhaai commented May 19, 2022

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] Test A
  • [] Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #3394 (fc5b095) into master (eb78dbd) will increase coverage by 0.00%.
The diff coverage is 83.53%.

❗ Current head fc5b095 differs from pull request most recent head 7cd5245. Consider uploading reports for the commit 7cd5245 to get more accurate results

@@           Coverage Diff            @@
##           master    #3394    +/-   ##
========================================
  Coverage   75.22%   75.22%            
========================================
  Files         236      237     +1     
  Lines       21953    22062   +109     
========================================
+ Hits        16514    16596    +82     
- Misses       4554     4578    +24     
- Partials      885      888     +3     
Impacted Files Coverage Δ
action/protocol/rewarding/protocol.go 77.13% <ø> (ø)
config/config.go 85.29% <ø> (ø)
state/factory/workingset.go 70.09% <0.00%> (ø)
actpool/queueworker.go 81.63% <81.63%> (ø)
actpool/actqueue.go 88.67% <85.24%> (-1.93%) ⬇️
actpool/actpool.go 85.90% <85.59%> (-1.01%) ⬇️
action/protocol/rewarding/fund.go 85.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb78dbd...7cd5245. Read the comment docs.

@Liuhaai Liuhaai closed this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant